Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(documentation): separate icon sets and implement pagination #4351

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

feat(documentation): separate icon sets and implement pagination #4351

wants to merge 33 commits into from

Conversation

oliverschuerch
Copy link
Contributor

@oliverschuerch oliverschuerch commented Dec 20, 2024 •
edited
Loading

Depends on #4136
Merge #4136 first to main, then update this one and merge it afterwards.

oliverschuerch and others added 30 commits December 3, 2024 15:08
@oliverschuerch
deps(components): install design-system-icons package and add copy ta…
907248d 
…sk to make icons available in the package for development
@oliverschuerch
fix(icons): remove fill and stroke attributes from svg elements
b98bec2
@oliverschuerch
feat(icons): update output of icons to make them available in css
6ea4619
@oliverschuerch
feat(styles): add post-icon mixin to use our icons in styles package.
26eee7a
@oliverschuerch
chore: update pnpm-lock
183ec7b
@oliverschuerch
feat(documentation): update icon docs page to show how to use the pos…
2b18dbc 
…t-icon mixin
@oliverschuerch
chore: changeset
727823c
@oliverschuerch
revert(components): revert component package, they will be added with…
6747db2 
… another pr
@oliverschuerch
chore(components): update lock file
e59d976
@oliverschuerch
fix(icons): rename closex-soliid source icons
815b525
@oliverschuerch
Merge branch 'main' into fix/post-icon-setup
0d08add
@oliverschuerch
Merge branch 'main' into fix/post-icon-setup
e8b6fc8
@oliverschuerch
chore(components): update autogenerated readme.md and components.d.ts…
8cede70 
… files
@oliverschuerch
refactor(icons): ui-icon template to use media queries
e16f29b
@oliverschuerch
chore(styles): update icons mixin and make it more backward compatible
56c77b9
@oliverschuerch
chore(styles): udpate post-icon mixin and use some more mask-image pr…
ff4ce88 
…operties
@oliverschuerch
feat(icons): improve icons v2 template
651449b
@oliverschuerch
chore(components): roll back post-icon component to use mask-image wi…
0287ac5 
…th the updated icons form the icons package
@oliverschuerch @gfellerph
Update packages/documentation/src/stories/foundations/icons/icon.docs…
285864f 
….mdx

Co-authored-by: Philipp Gfeller <[email protected]>
@oliverschuerch @gfellerph
Update packages/documentation/src/stories/foundations/icons/icon.docs…
8f7ac21 
….mdx

Co-authored-by: Philipp Gfeller <[email protected]>
@oliverschuerch
Merge branch 'main' into fix/post-icon-setup
2133903 
# Conflicts:
#	packages/documentation/src/stories/foundations/icons/icon.styles.scss
@oliverschuerch
feat(documentation): upate icon documentation page
be23a95
@oliverschuerch
chore(style): add stylelint-disable-next-line property-no-vendor-pref…
aac356f 
…ix to keep maximum backwards compatibility
@oliverschuerch
Merge branch 'fix/post-icon-setup' into refactor/4063-refactor-the-ic…
dd9d849 
…ons-search-page
@oliverschuerch
test(components): fix e2e test of card-control component
2c7ce5d
@oliverschuerch
Merge branch 'fix/post-icon-setup' into refactor/4063-refactor-the-ic…
d039613 
…ons-search-page
@oliverschuerch
chore(icons): fix error and picture solid variant file names
2b21213
@oliverschuerch
chore(styles): add media mixins to mixin/index.scss
eb5af4f
@oliverschuerch
feat(documentation): separate icon sets on icon search page and impro…
b0a34c8 
…ve search with pagination
@oliverschuerch
chore: changesets
c9a5f5c
@oliverschuerch oliverschuerch requested review from a team as code owners December 20, 2024 14:22
@oliverschuerch oliverschuerch linked an issue Dec 20, 2024 that may be closed by this pull request
Refactor the icons search page #4063
Open
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 911c207

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@swisspost/design-system-styles Minor
@swisspost/design-system-documentation Minor
@swisspost/design-system-icons Minor
@swisspost/design-system-components-angular-workspace Patch
@swisspost/design-system-components Minor
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header-workspace Patch
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-styles-primeng-workspace Patch
@swisspost/design-system-intranet-header Minor
@swisspost/design-system-styles-primeng Minor
@swisspost/design-system-components-react Minor
@swisspost/design-system-components-angular Minor
@swisspost/design-system-intranet-header-showcase Patch
@swisspost/design-system-tokens Minor
@swisspost/design-system-migrations Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@oliverschuerch
Merge branch 'main' into refactor/4063-refactor-the-icons-search-page
e77c66f 
# Conflicts:
#	packages/documentation/src/stories/foundations/icons/search/search-icons.styles.scss
@swisspost-bot
Copy link
Contributor

swisspost-bot commented Dec 20, 2024 •
edited
Loading

Related Previews

@oliverschuerch oliverschuerch added the 🚂 PR train PR which follows another one. label Dec 20, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leagrdv leagrdv Awaiting requested review from leagrdv leagrdv is a code owner automatically assigned from swisspost/design-system-maintainers

@alizedebray alizedebray Awaiting requested review from alizedebray

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
🚂 PR train PR which follows another one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor the icons search page
2 participants
@oliverschuerch @swisspost-bot